WebGLShadowMap: cleanup and optimization #11198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaxry
commented
Apr 19, 2017
| // equal to inverse of the light's position | ||
|
|
||
| var elements = light.matrixWorld.elements; | ||
| shadowMatrix.makeTranslation( - elements[ 12 ], - elements[ 13 ], - elements[ 14 ] ); |
There was a problem hiding this comment.
Instead of creating shadowMatrix declaratively as before, I create it directly. Avoids an intermediate Vector3 but loses clarity. Is an intermediate Vector3 preferable after all?
| _vector3.setFromMatrixPosition( light.matrixWorld ).negate(); | ||
| _lights.pointShadowMatrix[ pointLength ].identity().setPosition( _vector3 ); | ||
|
|
||
| _lights.pointShadowMatrix[ pointLength ] = light.shadow.matrix; |
There was a problem hiding this comment.
This pattern resembles the pattern used by spotlights and directinal lights a few blocks above.
|
Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple pull request which reorganizes some shadow mapping code.
shadowMatrix) was calculated six times every frame for each point shadow used, despite only being used for spot/directional lights. Moved this calculation so it's only done for spot/directional lights.